Why does this C function not work every time?

sign into xpforum and you will get help there , it's like here q & a , they all seem to know about a p.c